[General] [Linux] Fixed Shining Stats For New Builds of Dolphin
gyroninja
gyroninja at tfwno.gf
Sun Jan 14 06:22:30 UTC 2018
On October 11, 2017 dolphin renamed a shared memory object which Shining
Stats was depending on to find MEM1, which is the gamecube's main
memory.
https://github.com/dolphin-emu/dolphin/commit/28d648b80278161e21e370e326be4de4a8645340
Instead of looking for a specific filename the logic has changed
to just looking for "shm".
For the more technical people a fish shell implementation of what the logic
it uses is as follow:
OLD
grep -m1 dolphinmem /proc/(pgrep dolphin-emu)/maps | cut -d "-" -f1
NEW
grep -m1 shm /proc/(pgrep dolphin-emu)/maps | cut -d "-" -f1
(Of course the actual implementation is in C++)
Switching to just looking for "shm" instead of "dolphinmem" means we
should be more resistent to them.
This does not affect the Windows version of detecting MEM1 because it
uses a more complicated heuristic of detecting MEM1 in which it searches
for a memory region of the right size and permissions. On Linux we are
able to use a much simpler way to find the right offset.
More information about the General
mailing list